-
Notifications
You must be signed in to change notification settings - Fork 3
Edge Entry Prototype #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etGraph that can properly handle added links. (D3NetGraph was not able to handle new links)
… control of display.
…ed when the user presses Enter.
… exact match, not appearsIn
…e and target nodes.
…target node is not selected.
… Circle size is determined by the number of links you have.
benloh
pushed a commit
that referenced
this pull request
Jan 8, 2024
Prettier/ESLint Configuration Updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at an Edge Entry interface.
TO TEST
edge-entry
branch.npm install
npm run dev
http://localhost:3000
Create a New Edge
Edit an Existing Edge
RATIONALE
Getting the UI interactions right for this ended up being much more hairy than I originally thought. The general idea with this approach was to minimize the number of clicks one would have to make while adding/editing nodes and edges. So rather than having a completely separate Edge Entry UI, I thought we could take advantage of the node already selected by the NODE SELECTOR. You would use the NODE SELECTOR to do any node editing. And then can quickly add related edges. Through a quirk of the UI, the selected SOURCE node remains selected after you submit the edge, so you can quickly add a second edge.
Another goal was to support quick data entry via the keyboard. This isn't quite there yet, but it's close. We can refine the workflow some more so that you can quickly enter data dynamically with the keyboard.
The challenge is that the NODE SELECTOR and EDGE SELECTOR objects then have all these different modes and serve different display/edit purposes. So we have to carefully manage those states and make the transitions as intuitive as possible (e.g. letting the user know when they can and cannot edit the contents). It still needs some refinement.
NEW FEATURES
ISSUES